Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA Dockerfile #409

Merged
merged 2 commits into from
May 31, 2022
Merged

Fix CUDA Dockerfile #409

merged 2 commits into from
May 31, 2022

Conversation

muellerzr
Copy link
Collaborator

Include Git in the CUDA Docker image

What does this add?

This PR makes the Dockerfile install git in the final user image, as it's currently not present and is needed for the CI.

Why is it needed?

The CI operates on checking out the current commit and running the tests, as a result git was needed.

@muellerzr muellerzr added the enhancement New feature or request label May 27, 2022
@muellerzr muellerzr requested a review from sgugger May 27, 2022 17:54
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 27, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muellerzr muellerzr merged commit 94d88fb into main May 31, 2022
@muellerzr muellerzr deleted the fix-dockerfile branch May 31, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants