Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some parameter setting does not work for CPU DDP and bf16 fail in… #527

Merged
merged 3 commits into from
Jul 18, 2022
Merged

fix some parameter setting does not work for CPU DDP and bf16 fail in… #527

merged 3 commits into from
Jul 18, 2022

Conversation

sywangyi
Copy link
Contributor

… DDP path

Signed-off-by: Wang, Yi A yi.a.wang@intel.com

… DDP path

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

@sgugger @yao-matrix please help review

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

src/accelerate/commands/launch.py Outdated Show resolved Hide resolved
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
…t "127.0.0.1" when DDP is used in one machine

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 18, 2022

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger merged commit ddedeb4 into huggingface:main Jul 18, 2022
@sgugger
Copy link
Collaborator

sgugger commented Jul 18, 2022

Thansk again for your contribution!

@sywangyi sywangyi deleted the ddp_cpu_fix branch December 15, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants