Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename test extras to testing #545

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Rename test extras to testing #545

merged 3 commits into from
Jul 21, 2022

Conversation

muellerzr
Copy link
Collaborator

Super tiny nit, but keeps it inline with how transformers has their extras setup for tests. Mostly so I don't have to keep digging to see if I need to do pip install -e .[tests] pip install -e .[testing] pip install -e .[test] when bouncing back and forth between testing transformers and accelerate

@muellerzr muellerzr requested a review from sgugger July 21, 2022 15:54
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 21, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@muellerzr muellerzr merged commit 27d8d45 into main Jul 21, 2022
@muellerzr muellerzr deleted the testing branch July 21, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants