Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production testing + fix failing CI #547

Merged
merged 14 commits into from
Jul 21, 2022
Merged

Add production testing + fix failing CI #547

merged 14 commits into from
Jul 21, 2022

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Jul 21, 2022

Adds a production stage to the CI so that barebones testing without any added dependencies can be checked on the git ci first to ensure that trickle-down breakages cannot occur.

Specifically breaks down the big_modeling into its own ci matrix and adds a core to the matrix

Also removes unused evaluate test since it adds a dep to the main library. Not wondering if it'd be good for us soon to leave test_script in the main lib but migrate out all the other test scripts that might want or need external deps to a seperate folder at some point

@muellerzr muellerzr added the bug Something isn't working label Jul 21, 2022
@muellerzr muellerzr requested a review from sgugger July 21, 2022 17:08
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 21, 2022

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr changed the title Add production testing Add production testing + fix failing CI Jul 21, 2022
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding those tests!

@muellerzr muellerzr merged commit fdf4715 into main Jul 21, 2022
@muellerzr muellerzr deleted the prod branch July 21, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants