Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create good defaults in accelerate launch #553

Merged
merged 7 commits into from
Jul 22, 2022
Merged

Create good defaults in accelerate launch #553

merged 7 commits into from
Jul 22, 2022

Conversation

muellerzr
Copy link
Collaborator

Creates good defaults for unconfigured accelerate launch usage so that the user doesn't have to think much on it. (and actually support not needing to do accelerate config again)

@muellerzr muellerzr added the enhancement New feature or request label Jul 22, 2022
@muellerzr muellerzr requested a review from sgugger July 22, 2022 12:15
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 22, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also log warnings here, to make sure the user is not surprised by the magical defaults?

@muellerzr muellerzr requested a review from sgugger July 22, 2022 12:54
src/accelerate/commands/launch.py Outdated Show resolved Hide resolved
src/accelerate/commands/launch.py Outdated Show resolved Hide resolved
@muellerzr muellerzr requested a review from sgugger July 22, 2022 13:05
@muellerzr muellerzr merged commit 6c4edc3 into main Jul 22, 2022
@muellerzr muellerzr deleted the fix-args branch July 22, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants