Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove check for main process for trackers initialization #643

Merged
merged 2 commits into from
Aug 20, 2022
Merged

remove check for main process for trackers initialization #643

merged 2 commits into from
Aug 20, 2022

Conversation

Gladiator07
Copy link
Contributor

@Gladiator07 Gladiator07 commented Aug 19, 2022

Made the changes as discussed in this PR.

@muellerzr

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 19, 2022

The documentation is not available anymore as the PR was closed or merged.

@muellerzr
Copy link
Collaborator

Thanks! Do you want to try to update the complete examples in this too? (The last spot would be in the docs, but I can update that :) )

@Gladiator07
Copy link
Contributor Author

Sure, I will update all the example scripts in the examples folder in this PR :)

@muellerzr
Copy link
Collaborator

@Gladiator07 great! It should just be the complete_nlp_example and complete_cv_example

@Gladiator07
Copy link
Contributor Author

@muellerzr but many of the example scripts have the is_main_process check (for instance here). Should I update them as well or just complete_nlp_example and complete_cv_example ?

@muellerzr
Copy link
Collaborator

Ah, great point! Yes in that case those would be great to have done as well! :)

@Gladiator07
Copy link
Contributor Author

Hi @muellerzr, I have removed the is_main_process check from all example scripts. Please check it once.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@muellerzr muellerzr merged commit 36420f5 into huggingface:main Aug 20, 2022
@Gladiator07 Gladiator07 deleted the update-tracking-example branch August 20, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants