馃搱 Add GTM #119
Merged
馃搱 Add GTM #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
approved these changes
Apr 26, 2023
Co-authored-by: Pierric Cistac <Pierrci@users.noreply.github.com>
julien-c
reviewed
Apr 27, 2023
| <script> | ||
| if (["hf.co", "huggingface.co"].includes(window.location.hostname)) { | ||
| const script = document.createElement("script"); | ||
| script.src = "https://www.googletagmanager.com/gtag/js?id=G-8Q63TH4CSL"; |
There was a problem hiding this comment.
but this should be made configurable through an env var no?
There was a problem hiding this comment.
It's hardcoded on moon-landing so I just did the same thing, but yes I agree.
SBrandeis
reviewed
Apr 27, 2023
Comment on lines
+33
to
+34
| gtag("js", new Date()); | ||
| /// ^ See https://developers.google.com/tag-platform/gtagjs/install |
There was a problem hiding this comment.
I think it's missing:
gtag("config", "G-8Q63TH4CSL")There was a problem hiding this comment.
ah maybe, I thought it was redundant with ?id=G-8Q63TH4CSL in the URL of the script, but maybe it's not indeed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following Hub setup.
closes #114