Fix ram in prod (#280)

* fix: 🐛 reserve 256M for the API and nginx pods The API service seems to need about 52M: ``` process_virtual_memory_bytes 7.59681024e+08 process_resident_memory_bytes 5.2195328e+07 ``` * fix: 🐛 remove the PrometheusMiddleware to reduce the RAM usage Hopefully it fixes #279. See tiangolo/fastapi#4041
huggingface · May 17, 2022 · 443f00f · 443f00f
1 parent 2254754
commit 443f00f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 24 deletions.
diff --git a/infra/charts/datasets-server/env/prod.yaml b/infra/charts/datasets-server/env/prod.yaml
@@ -53,8 +53,10 @@ reverseProxy:
   resources:
     requests:
       cpu: 1
+      memory: "256Mi"
     limits:
       cpu: 1
+      memory: "256Mi"
 
 api:
   replicas: 2
@@ -65,8 +67,10 @@ api:
   resources:
     requests:
       cpu: 1
+      memory: "256Mi"
     limits:
       cpu: 1
+      memory: "256Mi"
 
 datasetsWorker:
   replicas: 3

diff --git a/services/api/poetry.lock b/services/api/poetry.lock
diff --git a/services/api/pyproject.toml b/services/api/pyproject.toml
@@ -9,10 +9,10 @@ huggingface-hub = "^0.5.1"
 libcache = { path = "../../libs/libcache", develop = true }
 libqueue = { path = "../../libs/libqueue", develop = true }
 libutils = { path = "../../libs/libutils", develop = true }
+prometheus-client = "^0.14.1"
 python = "3.9.6"
 python-dotenv = "^0.20.0"
 starlette = "^0.16.0"
-starlette-prometheus = "^0.9.0"
 uvicorn = "^0.14.0"
 watchdog = { extras = ["watchmedo"], version = "^2.1.3" }
 

diff --git a/services/api/src/api/app.py b/services/api/src/api/app.py
@@ -8,7 +8,6 @@
 from starlette.middleware.gzip import GZipMiddleware
 from starlette.routing import Mount, Route
 from starlette.staticfiles import StaticFiles
-from starlette_prometheus import PrometheusMiddleware
 
 from api.config import (
     APP_HOSTNAME,
@@ -45,7 +44,7 @@ def create_app() -> Starlette:
     show_assets_dir(ASSETS_DIRECTORY)
     prometheus = Prometheus()
 
-    middleware = [Middleware(GZipMiddleware), Middleware(PrometheusMiddleware, filter_unhandled_paths=True)]
+    middleware = [Middleware(GZipMiddleware)]
     routes = [
         Mount("/assets", app=StaticFiles(directory=init_assets_dir(ASSETS_DIRECTORY), check_dir=True), name="assets"),
         Route("/cache-reports", endpoint=cache_reports_endpoint),