Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasets 2.19.1 with hotfix to shorten long logs #2783

Merged
merged 6 commits into from
May 9, 2024

Conversation

albertvillanova
Copy link
Member

Update datasets 2.19.1 with hotfix to shorten long logs.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Feel free to merge when the merge conflicts are fixed

@albertvillanova
Copy link
Member Author

There is an incompatibility after the merge of:

When I try to lock the poetry files, I get:

Because huggingface-hub[hf-transfer] (0.20.0.dev0) @ git+https://github.com/huggingface/huggingface_hub.git@657a1bdcc0545309463e8651f62010154e9b3792 depends on huggingface-hub (0.20.0.dev0) @ git+https://github.com/huggingface/huggingface_hub.git@657a1bdcc0545309463e8651f62010154e9b3792
and datasets[audio,vision] (2.19.1) @ git+https://github.com/huggingface/datasets.git@3638183e2f7e0dce8924e46e7cc21bf6d5d7adfb depends on huggingface-hub (>=0.21.2), huggingface-hub[hf-transfer] (0.20.0.dev0) @ git+https://github.com/huggingface/huggingface_hub.git@657a1bdcc0545309463e8651f62010154e9b3792 is incompatible with datasets[audio,vision] (2.19.1) @ git+https://github.com/huggingface/datasets.git@3638183e2f7e0dce8924e46e7cc21bf6d5d7adfb.
And because libcommon (0.6.8) @ file:///home/albert/projects/forks/huggingface/datasets-server/libs/libcommon depends on datasets[audio,vision] (2.19.1) @ git+https://github.com/huggingface/datasets.git@3638183e2f7e0dce8924e46e7cc21bf6d5d7adfb, huggingface-hub[hf-transfer] (0.20.0.dev0) @ git+https://github.com/huggingface/huggingface_hub.git@657a1bdcc0545309463e8651f62010154e9b3792 is incompatible with libcommon (0.6.8) @ file:///home/albert/projects/forks/huggingface/datasets-server/libs/libcommon.
So, because cache-maintenance depends on libcommon (0.6.8) @ file:///home/albert/projects/forks/huggingface/datasets-server/libs/libcommon which depends on huggingface-hub[hf-transfer] (0.20.0.dev0) @ git+https://github.com/huggingface/huggingface_hub.git@657a1bdcc0545309463e8651f62010154e9b3792, version solving failed.

@albertvillanova
Copy link
Member Author

I don't know why it sees 0.20.0.dev0 as the version of huggingface-hub...

@albertvillanova
Copy link
Member Author

I get the same issue even on the main branch:

git checkout main
cd jobs/cache_maintenance
poetry@1.8.2 lock --no-update

Do you have the same issue?

@albertvillanova
Copy link
Member Author

Apparently, it was an issue with my local Python environments.

I deleted my .venv directories and then I locked the poetry files with success.

@albertvillanova albertvillanova merged commit 54196d5 into main May 9, 2024
22 checks passed
@albertvillanova albertvillanova deleted the update-datasets-2.19.1-hotfix branch May 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants