Add duration to cached steps #2967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duration is computed using corresponding job's started_at time
not sure it's needed.....
…nse and store it in JobResult
polinaeterna
commented
Jul 4, 2024
| @@ -147,3 +149,7 @@ def test_serialize_and_truncate_does_not_raise(obj: Any, max_bytes: int, expecte | |||
| def test_serialize_and_truncate_raises(obj: Any, max_bytes: int) -> None: | |||
| with pytest.raises(SmallerThanMaxBytesError): | |||
| serialize_and_truncate(obj=obj, max_bytes=max_bytes) | |||
|
|
|||
|
|
|||
| def test_get_duration() -> None: | |||
There was a problem hiding this comment.
idk if that's even needed...
| @@ -107,6 +107,7 @@ def run_job(self) -> JobResult: | |||
| "job_runner_version": self.job_runner_version, | |||
| "is_success": False, | |||
| "output": None, | |||
| "duration": get_duration_or_none(self.job_info["started_at"]), | |||
There was a problem hiding this comment.
this is dumb but otherwise mypy warns that Optional[datetime] is being passed instead of datetime because in theory job_info["started_at"] might be None if a job has not started yet.
| @@ -115,6 +117,8 @@ def test_backfill(priority: Priority, app_config: AppConfig) -> None: | |||
| assert job_result["is_success"] | |||
| assert job_result["output"] is not None | |||
| assert job_result["output"]["content"] == {"key": "value"} | |||
| assert job_result["duration"] is not None | |||
There was a problem hiding this comment.
this is the only test that checks that duration is set as expected for successful jobs. should I test it anywhere else?
There was a problem hiding this comment.
sounds good to me, though the test could be named test_run_job_and_finish though
lhoestq
approved these changes
Jul 4, 2024
| @@ -115,6 +117,8 @@ def test_backfill(priority: Priority, app_config: AppConfig) -> None: | |||
| assert job_result["is_success"] | |||
| assert job_result["output"] is not None | |||
| assert job_result["output"]["content"] == {"key": "value"} | |||
| assert job_result["duration"] is not None | |||
There was a problem hiding this comment.
sounds good to me, though the test could be named test_run_job_and_finish though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #2892
As suggested in #2908 (review), this adds duration field to cached responses. Duration is computed using
started_atfield of a corresponding job.Note that this PR adds new fields to major libcommon dtos
JobInfoandJobResult.