Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 馃帯 use cache (gha) when building the docker images #313

Merged
merged 2 commits into from
May 25, 2022

Conversation

@severo
Copy link
Collaborator Author

severo commented May 25, 2022

Results

First attempt: https://github.com/huggingface/datasets-server/runs/6595660098?check_suite_focus=true

  • admin: built in 2m 42s.
  • api: built in 2m 39s.
  • worker: built in 14m 58s.

Second attempt (relaunching the build manually): https://github.com/huggingface/datasets-server/runs/6595942870?check_suite_focus=true

  • admin: built in 3m 10s. <- NO CACHE USED ?!
  • api: built in 2m 37s. <- NO CACHE USED ?!
  • worker: built in 26s <- CACHE WORKED !!!

@severo
Copy link
Collaborator Author

severo commented May 25, 2022

The issue seems to be that only one cache is used for the three workflows in the matrix. Let's find how to get one cache per workflow.

@severo
Copy link
Collaborator Author

severo commented May 25, 2022

YEAHHHHHHHHHHHHH

14 minutes to 43 seconds !!!!!!!!

Capture d鈥檈虂cran 2022-05-25 a虁 18 39 47

Capture d鈥檈虂cran 2022-05-25 a虁 18 39 56

@severo severo merged commit 7c7a076 into main May 25, 2022
@severo severo deleted the use-cache-in-docker-build branch May 25, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant