fix: 馃悰 optimize the query to get the list of valid datasets #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimization: avoid getting first all the dataset names from the splits, and then put them into a set: it's a lot quicker to use distinct to only get the distinct name from mongo. fixes #326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimization: avoid getting first all the dataset names from the splits,
and then put them into a set: it's a lot quicker to use distinct to only
get the distinct name from mongo.
fixes #326
On a dump of the production database, it now takes 75ms
instead of 2 seconds! 馃ゲ
For the record: I use cProfile to profile the calls