Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add basis for the docs #421

Merged
merged 14 commits into from
Jun 28, 2022
Merged

feat: 🎸 add basis for the docs #421

merged 14 commits into from
Jun 28, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Jun 27, 2022

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 27, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some nits:

docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/splits.mdx Outdated Show resolved Hide resolved
docs/source/splits.mdx Outdated Show resolved Hide resolved
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun to read and learn more about datasets-server! Left some minor suggestions for clarity :)

docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/splits.mdx Outdated Show resolved Hide resolved
docs/source/rows.mdx Outdated Show resolved Hide resolved
docs/source/valid.mdx Outdated Show resolved Hide resolved
docs/source/valid.mdx Outdated Show resolved Hide resolved
docs/source/api_reference.mdx Outdated Show resolved Hide resolved
docs/source/api_reference.mdx Outdated Show resolved Hide resolved
severo and others added 4 commits June 28, 2022 10:09
Co-authored-by: Mario Šaško <mario@huggingface.co>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Mario Šaško <mario@huggingface.co>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@severo
Copy link
Collaborator Author

severo commented Jun 28, 2022

Thanks a lot @mariosasko and @stevhliu for the improvements. I've included them

@severo severo merged commit 5860f15 into main Jun 28, 2022
@severo severo deleted the add-docs branch June 28, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants