Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hub ci for tests #499

Merged
merged 22 commits into from
Aug 5, 2022
Merged

Use hub ci for tests #499

merged 22 commits into from
Aug 5, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Aug 4, 2022

No description provided.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 4, 2022

The documentation is not available anymore as the PR was closed or merged.

instead of relying on huggingface_hub and having to HF_ENDPOINT to it,
we just rely on datasets, which raises an exception in that case (we
have to rely on the error message, which is not very good). Also:
disable tests for the moment, because the datasets have been deleted.
also: update huggingface-hub
for that we have to use huggingface_hub. We pass HF_ENDPOINT.
And remove EXTERNAL_AUTH_URL, to replace it with HF_AUTH_PATH, a
relative path to HF_ENDPOINT.
Using the path from the hub: "/api/datasets/%s/auth-check"
All the datasets are created on the fly (then delete afterward) on
https://hub-ci.huggingface.co. No more tests against the prod Hub.

A lot of tests have been disabled and should be created again as
fixtures.
@severo severo marked this pull request as ready for review August 5, 2022 18:29
@severo severo merged commit 5e8f63b into main Aug 5, 2022
@severo severo deleted the use-hub-ci-for-tests branch August 5, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants