Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code snippet in docs #583

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Simplify code snippet in docs #583

merged 2 commits into from
Sep 23, 2022

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Sep 22, 2022 •
edited

We can use directly the method:

response.json()

because the inferred encoding from the headers is the right one:

In [6]: response.encoding
Out[6]: 'utf-8'

@HuggingFaceDocBuilder
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@albertvillanova albertvillanova changed the title Simplify code snippet in valid docs Simplify code snippet in docs Sep 22, 2022
@HuggingFaceDocBuilder
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@severo severo self-requested a review September 23, 2022 11:42
severo
severo approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@severo
Copy link
Collaborator

severo commented Sep 23, 2022

I let you merge

@albertvillanova albertvillanova merged commit df6161d into main Sep 23, 2022
@albertvillanova albertvillanova deleted the simplify-docs-valid branch September 23, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severo severo severo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertvillanova @HuggingFaceDocBuilder @severo