Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sequence of dicts #603

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Support Sequence of dicts #603

merged 5 commits into from
Oct 10, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Oct 10, 2022 •
edited

See #602

@severo severo changed the title 602 rowspostprocessing Support Sequence of dicts Oct 10, 2022
@severo
Copy link
Collaborator Author

severo commented Oct 10, 2022

The CI seems to be failing for an unrelated reason. I'll try to fix it here though

albertvillanova
albertvillanova approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for the target issue seems good to me:

As you said, the CI failures are due to an unrelated issue: requests.exceptions.HTTPError: 400 Client Error: Bad Request for url:...

services/worker/src/worker/features.py Outdated Show resolved Hide resolved
severo and others added 3 commits October 10, 2022 14:31
@severo @albertvillanova
Update services/worker/src/worker/features.py
4630061 
Co-authored-by: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com>
@severo
feat: 🎸 upgrade datasets and huggingface_hub
0e461ff
@severo
fix: 🐛 align token management with datasets and huggingface_hub
23623bc 
adopt use_auth_token
@severo severo merged commit 422bea8 into main Oct 10, 2022
@severo severo deleted the 602-rowspostprocessing branch October 10, 2022 13:30
This was referenced Oct 10, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova approved these changes

@lhoestq lhoestq Awaiting requested review from lhoestq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@severo @albertvillanova