Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🎡 remove the token for codecov since the repo is public #633

Merged
merged 7 commits into from
Nov 8, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Nov 8, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@f49e9e5). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 78e9150 differs from pull request most recent head fa2e282. Consider uploading reports for the commit fa2e282 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage        ?   88.27%           
=======================================
  Files           ?       45           
  Lines           ?     2038           
  Branches        ?        0           
=======================================
  Hits            ?     1799           
  Misses          ?      239           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severo
Copy link
Collaborator Author

severo commented Nov 8, 2022

@severo severo merged commit 0a10dd7 into main Nov 8, 2022
@severo severo deleted the fix-codecov-ci branch November 8, 2022 19:29
severo added a commit that referenced this pull request Nov 10, 2022
(should have been done in #633)
severo added a commit that referenced this pull request Nov 15, 2022
* chore: 🤖 prepare databases migration job

* ci: 🎡 fix directories to watch for changes

* ci: 🎡 remove codecov secret

(should have been done in #633)

* feat: 🎸 implement the migration logic

* refactor: 💡 rename env var

* feat: 🎸 add the migration image to the list

* feat: 🎸 add a job in the Helm chart to launch migration

* refactor: 💡 rename migration to mongodb_migration

more precise, and fixes an issue with the migration.py file

* feat: 🎸 remove underscore from variables in Helm chart

* feat: 🎸 update docker image

* feat: 🎸 mount the assets volume, even if it's not needed

A better fix would be to not include assets management in libcommon
(which is only used to get the debug level from the env)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants