Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ask access #652

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Fix ask access #652

merged 3 commits into from
Nov 29, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Nov 29, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Base: 84.22% // Head: 85.25% // Increases project coverage by +1.02% 🎉

Coverage data is based on head (b9b950d) compared to base (8e5f876).
Patch coverage: 84.61% of modified lines in pull request are covered.

❗ Current head b9b950d differs from pull request most recent head 847baf5. Consider uploading reports for the commit 847baf5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   84.22%   85.25%   +1.02%     
==========================================
  Files          53       35      -18     
  Lines        2587     1675     -912     
==========================================
- Hits         2179     1428     -751     
+ Misses        408      247     -161     
Flag Coverage Δ
jobs_mongodb_migration ?
libs_libcommon 85.22% <84.61%> (+0.44%) ⬆️
services_admin 84.45% <ø> (+4.59%) ⬆️
services_api 85.94% <ø> (+4.50%) ⬆️
workers_first_rows ?
workers_splits ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/libcommon/src/libcommon/dataset.py 54.34% <60.00%> (+8.89%) ⬆️
libs/libcommon/tests/test_dataset.py 100.00% <100.00%> (ø)
...ngodb_migration/src/mongodb_migration/migration.py
workers/first_rows/tests/test_features.py
...s/mongodb_migration/src/mongodb_migration/check.py
...db_migration/migrations/_20221110230400_example.py
workers/first_rows/src/first_rows/config.py
jobs/mongodb_migration/tests/test_collector.py
...ngodb_migration/src/mongodb_migration/collector.py
.../migrations/_20221116133500_queue_job_add_force.py
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severo severo merged commit 1233c2f into main Nov 29, 2022
@severo severo deleted the fix-ask-access branch November 29, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants