Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty commits #665

Merged
merged 7 commits into from
Dec 20, 2022
Merged

Fix empty commits #665

merged 7 commits into from
Dec 20, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Dec 20, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Base: 87.88% // Head: 87.73% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (0087a0f) compared to base (bd6aae3).
Patch has no changes to coverable lines.

❗ Current head 0087a0f differs from pull request most recent head 72daaba. Consider uploading reports for the commit 72daaba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
- Coverage   87.88%   87.73%   -0.16%     
==========================================
  Files          35       48      +13     
  Lines        1775     1614     -161     
==========================================
- Hits         1560     1416     -144     
+ Misses        215      198      -17     
Flag Coverage Δ
jobs_mongodb_migration 84.26% <ø> (?)
libs_libcommon ?
services_admin 88.45% <ø> (ø)
services_api 89.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/libcommon/tests/test_simple_cache.py
libs/libcommon/src/libcommon/dataset.py
libs/libcommon/src/libcommon/exceptions.py
libs/libcommon/tests/test_queue.py
libs/libcommon/src/libcommon/queue.py
libs/libcommon/tests/test_storage.py
libs/libcommon/tests/test_worker.py
libs/libcommon/tests/test_config.py
libs/libcommon/tests/test_dataset.py
libs/libcommon/src/libcommon/log.py
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

there is no patched version at the moment, so... ignoring to pass the CI
@severo severo merged commit 598e917 into main Dec 20, 2022
@severo severo deleted the fix-empty-commits branch December 20, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants