Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 speed-up docker build #669

Merged
merged 2 commits into from
Dec 23, 2022
Merged

chore: 🤖 speed-up docker build #669

merged 2 commits into from
Dec 23, 2022

Conversation

severo
Copy link
Collaborator

@severo severo commented Dec 23, 2022

in the next builds, the cache will be used if only src/ has been modified, which should help mostly with the workers/datasets_based image, because the poetry install of dependencies takes a lot of time.

in the next builds, the cache will be used if only src/ has been
modified, which should help mostly with the workers/datasets_based
image, because the poetry install of dependencies takes a lot of time.
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Base: 87.97% // Head: 87.92% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (65e9b7e) compared to base (ac28b95).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   87.97%   87.92%   -0.06%     
==========================================
  Files          67       48      -19     
  Lines        2920     1623    -1297     
==========================================
- Hits         2569     1427    -1142     
+ Misses        351      196     -155     
Flag Coverage Δ
jobs_mongodb_migration 84.33% <ø> (ø)
libs_libcommon ?
services_admin 88.85% <ø> (ø)
services_api 89.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/libcommon/src/libcommon/queue.py
libs/libcommon/tests/test_dataset.py
libs/libcommon/tests/test_simple_cache.py
libs/libcommon/src/libcommon/storage.py
libs/libcommon/tests/test_storage.py
libs/libcommon/src/libcommon/log.py
libs/libcommon/src/libcommon/config.py
libs/libcommon/tests/test_worker.py
libs/libcommon/src/libcommon/simple_cache.py
libs/libcommon/tests/test_worker_loop.py
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severo
Copy link
Collaborator Author

severo commented Dec 23, 2022

Merging, as the remaining issue is unrelated

@severo severo merged commit e31129e into main Dec 23, 2022
@severo severo deleted the speed-up-docker-build branch December 23, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants