Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add indexes, based on recommendations from mongo cloud #728

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

severo
Copy link
Collaborator

@severo severo commented Jan 30, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023

Codecov Report

Base: 90.14% // Head: 90.14% // No change to project coverage 👍

Coverage data is based on head (22b7624) compared to base (7cc7367).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          99       99           
  Lines        5051     5051           
=======================================
  Hits         4553     4553           
  Misses        498      498           
Flag Coverage Δ
jobs_mongodb_migration 83.46% <ø> (ø)
libs_libcommon 91.40% <ø> (ø)
services_admin 87.12% <ø> (ø)
services_api 90.13% <ø> (ø)
workers_datasets_based 92.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/libcommon/src/libcommon/queue.py 96.10% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ! This way we can follow more easily the jobs per dataset ?

@severo severo merged commit eaa2c47 into main Jan 31, 2023
@severo severo deleted the add-indexes branch January 31, 2023 12:23
@severo
Copy link
Collaborator Author

severo commented Jan 31, 2023

Hmmm, no, it was required for a query when we look for the next job in the queue. I had added the priority field, but the index was not right.
Our cloud mongo db provides some recommendations about the indexes that could be created, based on the past queries. I just used that.

@severo
Copy link
Collaborator Author

severo commented Jan 31, 2023

Capture d’écran 2023-01-31 à 13 31 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants