Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove mongo migration job execution on pre-install hook #738

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix: remove mongo migration job execution on pre-install hook #738

merged 1 commit into from
Jan 31, 2023

Conversation

rtrompier
Copy link
Collaborator

No description provided.

@rtrompier rtrompier requested a review from severo January 31, 2023 12:23
severo
severo approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks.

For the record: on install, as the job was run before the MongoDB even created ready (due to pre-install), it would fail and block the deployment. It's normally just needed when upgrading a version of the app.

@rtrompier rtrompier merged commit 042e8a8 into main Jan 31, 2023
@rtrompier rtrompier deleted the fix/mongo-migration-hook branch January 31, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severo severo severo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rtrompier @severo