Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 💍 ensure the database is ready in the tests #759

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

severo
Copy link
Collaborator

@severo severo commented Feb 1, 2023

add a dependency to the app_config fixture to be sure to have access to the database when running an individual test, with TEST_PATH="tests/test_worker.py" make test

add a dependency to the app_config fixture to be sure to have access to
the database when running an individual test, with
`TEST_PATH="tests/test_worker.py" make test`
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Base: 92.01% // Head: 92.01% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1459a90) compared to base (75ae5f7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
- Coverage   92.01%   92.01%   -0.01%     
==========================================
  Files          33       33              
  Lines        2205     2204       -1     
==========================================
- Hits         2029     2028       -1     
  Misses        176      176              
Flag Coverage Δ
workers_datasets_based 92.01% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
workers/datasets_based/tests/test_worker.py 100.00% <100.00%> (ø)
workers/datasets_based/tests/test_worker_loop.py 100.00% <100.00%> (ø)
.../datasets_based/tests/workers/test_dataset_info.py 100.00% <100.00%> (ø)
...rkers/datasets_based/tests/workers/test_parquet.py 100.00% <100.00%> (ø)
workers/datasets_based/tests/workers/test_sizes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@severo severo merged commit a968dc5 into main Feb 2, 2023
@severo severo deleted the fix-test-clean-database branch February 2, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants