Locally use volumes for workers code #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severo
requested changes
Feb 2, 2023
|
I ended up defining a separate docker-compose file for dev. This way the e2e tests can use the actual docker image that we may deploy. I introduced make dev-start |
severo
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
OK, nice!
Two small comments:
- it's not DRY (but it's not really a problem, I just read https://gordonc.bearblog.dev/dry-most-over-rated-programming-principle/ :P)
- it's only to make it easier to dev on the worker. We could extend this to have a dev environment on the services too
|
Yea we'll just have to remember to update both when modifying something, but it should be fine since they're next to each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way in a local dev env, one can restart a single worker container to apply their code changes instead of running
make stopandmake startagain