Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workers' errors derive from WorkerError #772

Merged

Conversation

albertvillanova
Copy link
Member

Make workers' errors derive from WorkerError, instead of parent CustomError.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 6, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@severo severo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It was incoherent

@albertvillanova
Copy link
Member Author

Apparently there is (again) a connectivity issue with http://azure.archive.ubuntu.com mirrors...
I will relaunch the CI failed jobs later.

@severo
Copy link
Collaborator

severo commented Feb 6, 2023

OK, Azure seems to work again. And there is an issue with the types: the signatures are not exactly the same

@albertvillanova
Copy link
Member Author

albertvillanova commented Feb 6, 2023

@severo, I have created GeneralWorkerError(WorkerError) and make errors in worker.py derive from it, while all workers' errors (inside workers dir) continue to derive from WorkerError.

Alternatively I could have renamed WorkerError to BaseWorkerError, create new WorkerError(BaseWorkerError) and make errors in worker.py derive from it, while all workers' errors (inside workers dir) now derive from BaseWorkerError.

What do you think is more clear?

@albertvillanova
Copy link
Member Author

The CI error is unrelated to this PR: https://github.com/huggingface/datasets-server/actions/runs/4105164627/jobs/7081642597

src/datasets_based/worker_loop.py:100: error: "WorkerFactory" has no attribute "app_config"

See:

@severo
Copy link
Collaborator

severo commented Feb 7, 2023

I think it's ok, now

@albertvillanova albertvillanova merged commit 763a6a2 into huggingface:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants