Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 ensure immutability of the configs #790

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Conversation

severo
Copy link
Collaborator

@severo severo commented Feb 8, 2023

if we decide to allow changing config parameters later, it will need to be explicit.

Depends on: #784

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 90.72% // Head: 90.72% // No change to project coverage 👍

Coverage data is based on head (3f4af2c) compared to base (761d16a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         105      105           
  Lines        5259     5259           
=======================================
  Hits         4771     4771           
  Misses        488      488           
Flag Coverage Δ
jobs_mongodb_migration 80.24% <ø> (ø)
libs_libcommon 92.80% <100.00%> (ø)
services_admin 87.13% <100.00%> (ø)
services_api 89.50% <100.00%> (ø)
workers_datasets_based 92.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/libcommon/src/libcommon/config.py 77.96% <100.00%> (ø)
services/admin/src/admin/config.py 94.00% <100.00%> (ø)
services/api/src/api/config.py 100.00% <100.00%> (ø)
...orkers/datasets_based/src/datasets_based/config.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HuggingFaceDocBuilder
Copy link
Collaborator

HuggingFaceDocBuilder commented Feb 8, 2023

The documentation is not available anymore as the PR was closed or merged.

Base automatically changed from create_resources_concept to main February 10, 2023 15:08
Copy link
Contributor

@AndreaFrancis AndreaFrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! It has more sense for configs

@severo severo marked this pull request as ready for review February 10, 2023 15:58
@severo severo merged commit a7f3ecd into main Feb 10, 2023
@severo severo deleted the ensure-immutable-config branch February 10, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants