Skip to content

Commit

Permalink
style
Browse files Browse the repository at this point in the history
  • Loading branch information
@lhoestq
lhoestq committed Oct 5, 2020
1 parent b806ac2 commit 193e3cb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion datasets/text/text.py
View file
@@ -1,7 +1,6 @@
import logging
from dataclasses import dataclass

import pandas as pd
import pyarrow as pa

import datasets
Expand Down

1 comment on commit 193e3cb

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show benchmarks

PyArrow==0.17.1

Show updated benchmarks!

Benchmark: benchmark_array_xd.json

metric read_batch_formatted_as_numpy after write_array2d read_batch_formatted_as_numpy after write_flattened_sequence read_batch_formatted_as_numpy after write_nested_sequence read_batch_unformated after write_array2d read_batch_unformated after write_flattened_sequence read_batch_unformated after write_nested_sequence read_col_formatted_as_numpy after write_array2d read_col_formatted_as_numpy after write_flattened_sequence read_col_formatted_as_numpy after write_nested_sequence read_col_unformated after write_array2d read_col_unformated after write_flattened_sequence read_col_unformated after write_nested_sequence read_formatted_as_numpy after write_array2d read_formatted_as_numpy after write_flattened_sequence read_formatted_as_numpy after write_nested_sequence read_unformated after write_array2d read_unformated after write_flattened_sequence read_unformated after write_nested_sequence write_array2d write_flattened_sequence write_nested_sequence
new / old (diff) 0.016545 / 0.011353 (0.005192) 0.014509 / 0.011008 (0.003501) 0.043855 / 0.038508 (0.005347) 0.028319 / 0.023109 (0.005210) 0.192402 / 0.275898 (-0.083496) 0.227911 / 0.323480 (-0.095568) 0.009469 / 0.007986 (0.001483) 0.004647 / 0.004328 (0.000319) 0.007551 / 0.004250 (0.003300) 0.042300 / 0.037052 (0.005248) 0.196594 / 0.258489 (-0.061896) 0.227737 / 0.293841 (-0.066103) 0.154836 / 0.128546 (0.026290) 0.119211 / 0.075646 (0.043565) 0.423556 / 0.419271 (0.004285) 0.526862 / 0.043533 (0.483329) 0.189431 / 0.255139 (-0.065708) 0.218295 / 0.283200 (-0.064904) 0.080411 / 0.141683 (-0.061272) 1.723869 / 1.452155 (0.271714) 1.833929 / 1.492716 (0.341213)

Benchmark: benchmark_indices_mapping.json

metric select shard shuffle sort train_test_split
new / old (diff) 0.037328 / 0.037411 (-0.000083) 0.017636 / 0.014526 (0.003110) 0.079560 / 0.176557 (-0.096997) 0.084109 / 0.737135 (-0.653026) 0.024454 / 0.296338 (-0.271884)

Benchmark: benchmark_iterating.json

metric read 5000 read 50000 read_batch 50000 10 read_batch 50000 100 read_batch 50000 1000 read_formatted numpy 5000 read_formatted pandas 5000 read_formatted tensorflow 5000 read_formatted torch 5000 read_formatted_batch numpy 5000 10 read_formatted_batch numpy 5000 1000 shuffled read 5000 shuffled read 50000 shuffled read_batch 50000 10 shuffled read_batch 50000 100 shuffled read_batch 50000 1000 shuffled read_formatted numpy 5000 shuffled read_formatted_batch numpy 5000 10 shuffled read_formatted_batch numpy 5000 1000
new / old (diff) 0.190962 / 0.215209 (-0.024247) 1.992340 / 2.077655 (-0.085315) 1.323002 / 1.504120 (-0.181118) 1.197763 / 1.541195 (-0.343432) 1.223816 / 1.468490 (-0.244674) 6.461175 / 4.584777 (1.876398) 5.702214 / 3.745712 (1.956501) 7.609121 / 5.269862 (2.339259) 6.729832 / 4.565676 (2.164155) 0.679618 / 0.424275 (0.255343) 0.011135 / 0.007607 (0.003528) 0.233004 / 0.226044 (0.006960) 2.261328 / 2.268929 (-0.007600) 1.561440 / 55.444624 (-53.883184) 1.374222 / 6.876477 (-5.502255) 1.409029 / 2.142072 (-0.733044) 7.013222 / 4.805227 (2.207995) 8.333363 / 6.500664 (1.832699) 9.157813 / 0.075469 (9.082344)

Benchmark: benchmark_map_filter.json

metric filter map fast-tokenizer batched map identity map identity batched map no-op batched map no-op batched numpy map no-op batched pandas map no-op batched pytorch map no-op batched tensorflow
new / old (diff) 13.081563 / 1.841788 (11.239775) 14.624645 / 8.074308 (6.550337) 14.959498 / 10.191392 (4.768106) 0.407439 / 0.680424 (-0.272984) 0.273266 / 0.534201 (-0.260935) 0.761112 / 0.579283 (0.181829) 0.588137 / 0.434364 (0.153773) 0.754386 / 0.540337 (0.214049) 1.509362 / 1.386936 (0.122426)
PyArrow==1.0
Show updated benchmarks!

Benchmark: benchmark_array_xd.json

metric read_batch_formatted_as_numpy after write_array2d read_batch_formatted_as_numpy after write_flattened_sequence read_batch_formatted_as_numpy after write_nested_sequence read_batch_unformated after write_array2d read_batch_unformated after write_flattened_sequence read_batch_unformated after write_nested_sequence read_col_formatted_as_numpy after write_array2d read_col_formatted_as_numpy after write_flattened_sequence read_col_formatted_as_numpy after write_nested_sequence read_col_unformated after write_array2d read_col_unformated after write_flattened_sequence read_col_unformated after write_nested_sequence read_formatted_as_numpy after write_array2d read_formatted_as_numpy after write_flattened_sequence read_formatted_as_numpy after write_nested_sequence read_unformated after write_array2d read_unformated after write_flattened_sequence read_unformated after write_nested_sequence write_array2d write_flattened_sequence write_nested_sequence
new / old (diff) 0.020860 / 0.011353 (0.009507) 0.013996 / 0.011008 (0.002988) 0.046947 / 0.038508 (0.008439) 0.032103 / 0.023109 (0.008994) 0.312140 / 0.275898 (0.036242) 0.366573 / 0.323480 (0.043093) 0.007260 / 0.007986 (-0.000725) 0.005746 / 0.004328 (0.001418) 0.006818 / 0.004250 (0.002568) 0.055727 / 0.037052 (0.018674) 0.319716 / 0.258489 (0.061227) 0.379642 / 0.293841 (0.085801) 0.168942 / 0.128546 (0.040396) 0.130241 / 0.075646 (0.054595) 0.476381 / 0.419271 (0.057110) 0.450675 / 0.043533 (0.407142) 0.315454 / 0.255139 (0.060315) 0.396101 / 0.283200 (0.112902) 0.106305 / 0.141683 (-0.035378) 1.830796 / 1.452155 (0.378641) 2.013479 / 1.492716 (0.520763)

Benchmark: benchmark_indices_mapping.json

metric select shard shuffle sort train_test_split
new / old (diff) 0.041495 / 0.037411 (0.004083) 0.022382 / 0.014526 (0.007856) 0.026970 / 0.176557 (-0.149586) 0.082971 / 0.737135 (-0.654164) 0.026621 / 0.296338 (-0.269718)

Benchmark: benchmark_iterating.json

metric read 5000 read 50000 read_batch 50000 10 read_batch 50000 100 read_batch 50000 1000 read_formatted numpy 5000 read_formatted pandas 5000 read_formatted tensorflow 5000 read_formatted torch 5000 read_formatted_batch numpy 5000 10 read_formatted_batch numpy 5000 1000 shuffled read 5000 shuffled read 50000 shuffled read_batch 50000 10 shuffled read_batch 50000 100 shuffled read_batch 50000 1000 shuffled read_formatted numpy 5000 shuffled read_formatted_batch numpy 5000 10 shuffled read_formatted_batch numpy 5000 1000
new / old (diff) 0.255967 / 0.215209 (0.040758) 2.508359 / 2.077655 (0.430704) 1.591478 / 1.504120 (0.087358) 1.625457 / 1.541195 (0.084262) 1.672627 / 1.468490 (0.204137) 6.747825 / 4.584777 (2.163048) 5.626386 / 3.745712 (1.880674) 7.513505 / 5.269862 (2.243643) 6.682341 / 4.565676 (2.116665) 0.642182 / 0.424275 (0.217907) 0.010103 / 0.007607 (0.002496) 0.260846 / 0.226044 (0.034802) 2.894089 / 2.268929 (0.625160) 1.973187 / 55.444624 (-53.471437) 1.894099 / 6.876477 (-4.982378) 1.906206 / 2.142072 (-0.235867) 6.527136 / 4.805227 (1.721908) 5.383635 / 6.500664 (-1.117029) 6.791891 / 0.075469 (6.716422)

Benchmark: benchmark_map_filter.json

metric filter map fast-tokenizer batched map identity map identity batched map no-op batched map no-op batched numpy map no-op batched pandas map no-op batched pytorch map no-op batched tensorflow
new / old (diff) 13.274523 / 1.841788 (11.432735) 14.022604 / 8.074308 (5.948296) 15.167367 / 10.191392 (4.975975) 1.108251 / 0.680424 (0.427827) 0.524528 / 0.534201 (-0.009673) 0.730733 / 0.579283 (0.151450) 0.593916 / 0.434364 (0.159552) 0.698869 / 0.540337 (0.158532) 1.494425 / 1.386936 (0.107489)

Please sign in to comment.