-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocalDatasetModuleFactoryWithoutScript extracts invalid builder name #4399
Comments
Ok, so
gives
gives |
The fix is:
|
I came through the same issue , just removing the last slash in the dataset path fixed it for me, may be this repo moderators could accept this as an accepted answer atleast if this could not be integrated
@apohllo consider making a pull request on this Thanks for the amazing contributions from huggingface people !! |
@apohllo Would you be interested in submitting a PR with the fix? |
@mariosasko here we go: TBH I haven't tested it yet, but should work, since this is a basic change. |
Describe the bug
Trying to load a local dataset raises an error indicating that the config builder has to have a name.
No error should be reported, since the call is completly valid.
Steps to reproduce the bug
Expected results
The dataset should be loaded.
Actual results
Environment info
datasets
version: 2.2.2The error is probably in line 795 in load.py:
os.path.basename
for a directory returns an empty string, rather than the name of the directory.The text was updated successfully, but these errors were encountered: