Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused py_utils objects #1916

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

albertvillanova
Copy link
Member

Remove unused/unnecessary py_utils functions/classes.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@lhoestq lhoestq merged commit 51dc5f5 into huggingface:master Feb 22, 2021
@lhoestq
Copy link
Member

lhoestq commented Feb 22, 2021

Hmmm this one broke master. I'm fixing it.

Maybe because your branch was outdated ?

@albertvillanova
Copy link
Member Author

Sorry @lhoestq, I forgot to update the imports... :/

@lhoestq
Copy link
Member

lhoestq commented Feb 22, 2021

It's fine, the CI should have caught this tbh. Not sure why it did't fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants