Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with not in place transforms and update DatasetDict #1947

Merged
merged 9 commits into from
Mar 1, 2021

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Feb 25, 2021

In #1883 were added the not in-place transforms flatten, remove_columns, rename_column and cast.

I added them to the documentation and added a paragraph on how to use them

You can preview the documentation here

I also added these methods to the DatasetDict class.

Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few minor comments, this is good to go :)
Thanks a lot!

docs/source/processing.rst Outdated Show resolved Hide resolved
docs/source/processing.rst Outdated Show resolved Hide resolved
src/datasets/dataset_dict.py Outdated Show resolved Hide resolved
src/datasets/dataset_dict.py Show resolved Hide resolved
src/datasets/dataset_dict.py Show resolved Hide resolved
src/datasets/dataset_dict.py Show resolved Hide resolved
src/datasets/dataset_dict.py Show resolved Hide resolved
@lhoestq lhoestq merged commit 9745965 into master Mar 1, 2021
@lhoestq lhoestq deleted the update-doc-with-not-in-place-transforms branch March 1, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants