New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorize Metric.compute signature to force keyword arguments only #2079

Merged

lhoestq merged 2 commits into huggingface:master from aiinnova:patch-1

Mar 23, 2021

Member

albertvillanova commented Mar 18, 2021

Minor refactoring of Metric.compute signature to force the use of keyword arguments, by using the single star syntax.

albertvillanova added 2 commits

March 18, 2021 16:02


          Fix Metric.compute signature using single star syntax

ae6679f


          Fix copyfunc to also copy defaults for keyword-only parameters

8756d9b

lhoestq approved these changes

View reviewed changes

Member

lhoestq left a comment

Thanks ! this is consistent with add and add_batch now :)

lhoestq merged commit 99da4c9 into huggingface:master

PhilipMay pushed a commit to PhilipMay/datasets that referenced this pull request


          Refactorize Metric.compute signature to force keyword arguments only (h…

e7b3694

…uggingface#2079)

* Fix Metric.compute signature using single star syntax

* Fix copyfunc to also copy defaults for keyword-only parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment