Add machine translated multilingual STS benchmark dataset #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipMay
changed the title
|
Hello dear maintainer, are there any comments or questions about this PR? |
lhoestq
reviewed
Mar 24, 2021
There was a problem hiding this comment.
Really cool thank you :)
The dataset script looks all good ! Good job.
The dummy data and the dataset_infos.json are also perfect :)
For the readme, can you follow the template for the README.md ? You can find the template here:
https://github.com/huggingface/datasets/tree/master/templates
Ideally it would be cool to fill the info for those sections at least:
- Dataset Summary
- Languages
- Data Instances
- Data Fields
- Data Splits
Let me know if you have questions about this !
- Dataset Summary - Languages - Data Instances - Data Fields - Data Splits
PhilipMay
force-pushed
the
stsb-multi-mt-dataset
branch
from
3b8a4ff
to
550d715
Compare
|
@iamollas thanks for the feedback. I did not see the template. |
|
Should be clean for merge IMO. |
lhoestq
approved these changes
Mar 29, 2021
|
@lhoestq CI is green. ;-) |
|
Thanks again ! this is awesome :) |
|
Thanks for merging. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also see here https://github.com/PhilipMay/stsb-multi-mt