Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIAM dataset - new citation details #2101

Merged
merged 12 commits into from Mar 23, 2021
Merged

MIAM dataset - new citation details #2101

merged 12 commits into from Mar 23, 2021

Conversation

eusip
Copy link
Contributor

@eusip eusip commented Mar 23, 2021

Hi @lhoestq, I have updated the citations to reference an OpenReview preprint.

@lhoestq
Copy link
Member

lhoestq commented Mar 23, 2021

Hi !
Looks like there's a unicode error in the new citation in the miam.py file.
Could you try to fix it ? Not sure from which character it comes from though

You can test if it works on your side with

RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_miam

@eusip
Copy link
Contributor Author

eusip commented Mar 23, 2021

Unicode error resolved!

@lhoestq lhoestq merged commit 349ac43 into huggingface:master Mar 23, 2021
PhilipMay pushed a commit to PhilipMay/datasets that referenced this pull request Mar 24, 2021
* miam dataset

* revision of  miam dataset based on HF feedback

* revision of README based on HF feedback

* re-run of isort on miam.py per 'check_code_quality'

* re-run of flake8 on miam.py per 'check_code_quality'

* re-run of black on miam.py

* re-run of black on miam.py

* update of anonymous citations

* debug of anonymous citations

* re-run of black on miam.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants