Fix incorrect assertion in builder.py #2110

dreamgonfly · 2021-03-25T10:39:20Z

Fix incorrect num_examples comparison assertion in builder.py

lhoestq · 2021-03-25T13:54:27Z

Hi ! The SplitInfo is not always available. By default you would get split_info.num_examples == 0
So unfortunately we can't use this assertion you suggested

dreamgonfly · 2021-04-10T23:53:50Z

Hi ! The SplitInfo is not always available. By default you would get split_info.num_examples == 0
So unfortunately we can't use this assertion you suggested

Then it would be better to just remove the assertion, because the existing assertion does nothing.

src/datasets/builder.py

lhoestq

Thanks.
You can ignore the CI fail on the documentation, this has been fixed on master

Fix incorrect assertion in builder.py

4cdc1ae

dreamgonfly commented Apr 10, 2021

View reviewed changes

src/datasets/builder.py Outdated Show resolved Hide resolved

Update src/datasets/builder.py

aaffe6a

lhoestq approved these changes Apr 12, 2021

View reviewed changes

lhoestq merged commit 49eee3a into huggingface:master Apr 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect assertion in builder.py #2110

Fix incorrect assertion in builder.py #2110

dreamgonfly commented Mar 25, 2021

lhoestq commented Mar 25, 2021

dreamgonfly commented Apr 10, 2021

lhoestq left a comment

Fix incorrect assertion in builder.py #2110

Fix incorrect assertion in builder.py #2110

Conversation

dreamgonfly commented Mar 25, 2021

lhoestq commented Mar 25, 2021

dreamgonfly commented Apr 10, 2021

lhoestq left a comment

Choose a reason for hiding this comment