Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GooAQ dataset added #2260

Merged
merged 11 commits into from May 7, 2021
Merged

GooAQ dataset added #2260

merged 11 commits into from May 7, 2021

Conversation

bhavitvyamalik
Copy link
Contributor

@bhavitvyamalik bhavitvyamalik commented Apr 25, 2021 •
edited

@lhoestq here the dataset is stored with Git LFS. Should I add option for manual downloading of dataset using git lfs pull post repo cloning or can we accommodate this in the current download_and_extract?

@bhavitvyamalik bhavitvyamalik marked this pull request as draft April 25, 2021 09:26
@lhoestq
Copy link
Member

lhoestq commented Apr 27, 2021

Thanks for adding this one !
The download manager does support downloading files on git lfs via their github url. No need for a manual download option ;)

@bhavitvyamalik bhavitvyamalik marked this pull request as ready for review May 3, 2021 19:29
lhoestq
lhoestq reviewed May 6, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks :)

My final comments:

datasets/gooaq/gooaq.py Outdated Show resolved Hide resolved
datasets/gooaq/README.md Outdated Show resolved Hide resolved
datasets/gooaq/README.md Show resolved Hide resolved
datasets/gooaq/README.md Outdated Show resolved Hide resolved
datasets/gooaq/gooaq.py Outdated Show resolved Hide resolved
datasets/gooaq/gooaq.py Outdated Show resolved Hide resolved
datasets/gooaq/README.md Outdated Show resolved Hide resolved
datasets/gooaq/gooaq.py Outdated Show resolved Hide resolved
reevesPAC
reevesPAC reviewed May 6, 2021
View reviewed changes
Copy link

@reevesPAC reevesPAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request #2260
This example-set is very informative, thanks.

lhoestq
lhoestq approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ! LGTM :)

@lhoestq lhoestq merged commit bb9a003 into huggingface:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reevesPAC reevesPAC reevesPAC left review comments

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhavitvyamalik @lhoestq @reevesPAC