Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ReadInstruction logic and update docs #2261

Merged
merged 6 commits into from May 17, 2021
Merged

Improve ReadInstruction logic and update docs #2261

merged 6 commits into from May 17, 2021

Conversation

mariosasko
Copy link
Collaborator

Improve ReadInstruction logic and docs.

lhoestq
lhoestq reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks !
It's indeed better this way.

Maybe let's describe the difference between the two rounding strategies in the doc ? (see my comment)

docs/source/splits.rst Outdated Show resolved Hide resolved
@mariosasko
Copy link
Collaborator Author

Ready for the final review

@mariosasko mariosasko requested a review from lhoestq May 15, 2021 13:44
lhoestq
lhoestq approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! LGTM :)

@lhoestq lhoestq merged commit bd3654a into huggingface:master May 17, 2021
@mariosasko mariosasko deleted the readinstruction-improvements branch May 17, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mariosasko @lhoestq