Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dataset cards #2348

Merged
merged 17 commits into from May 21, 2021
Merged

Conversation

gchhablani
Copy link
Contributor

@gchhablani gchhablani commented May 11, 2021

Adding tests for dataset cards

This PR will potentially remove the scripts being used for dataset tags and readme validation.

Additionally, this will allow testing dataset readmes by providing the name as follows:

pytest tests/test_dataset_cards.py::test_dataset_tags[fashion_mnist]

and

pytest tests/test_dataset_cards.py::test_readme_content[fashion_mnist]

or a combined test as:

pytest tests/test_dataset_cards.py::test_dataset_card[fashion_mnist]

@lhoestq

@gchhablani gchhablani changed the title Add dataset card tests Add tests for dataset cards May 11, 2021
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, thanks !

@gchhablani gchhablani marked this pull request as ready for review May 14, 2021 14:27
@gchhablani
Copy link
Contributor Author

gchhablani commented May 18, 2021

@lhoestq

Should I remove the scripts? or atleast remove running them from the CircleCI config?

Also, I hope it is okay that the combined method (metadata+content) is only a slow test, and for the Circle CI, I assume only non-slow tests are run? If yes, this would mean separate tests for content and metadata.

@lhoestq
Copy link
Member

lhoestq commented May 18, 2021

Also feel free to remove the scripts from the CI and also remove the scripts files :)

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks !!

@lhoestq lhoestq merged commit 6626659 into huggingface:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants