#2837 Use cache folder for lockfile #2887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
reviewed
Sep 21, 2021
src/datasets/load.py
Outdated
| @@ -452,8 +452,12 @@ def prepare_packaged_module(name): | |||
|
|
|||
| if force_local_path is None: | |||
| main_folder_path = os.path.join(datasets_modules_path if dataset else metrics_modules_path, short_name) | |||
| # Create the lock file where we know we have write permissions. | |||
| lock_path = main_folder_path + ".lock" | |||
| os.makedirs(main_folder_path, exist_ok=True) | |||
There was a problem hiding this comment.
You must notice line 678 that if force_download is set to True, the main_folder_path directory is deleted, which is an issue because it contains an open lock file. Therefore I would put the lock file it inside datasets_modules_path if dataset else metrics_modules_path instead
There was a problem hiding this comment.
Ah thank you!
Something like:
# Create the lock file where we know we have write permissions.
lock_path = (datasets_modules_path if dataset else metrics_modules_path) + f"{name}.lock"so that each dataset has their own lock file?
|
The CI fail about the meteor metric is unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2837
Use a cache folder directory to store the FileLock.
The issue was that the lock file was in a readonly folder.