Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 馃幐 add a function to get a dataset config's split names #2906

Merged
merged 13 commits into from
Oct 4, 2021

Conversation

severo
Copy link
Contributor

@severo severo commented Sep 14, 2021

Also: pass additional arguments (use_auth_token) to get private configs + info of private datasets on the hub

Questions:

@severo severo requested a review from lhoestq September 14, 2021 12:31
setup.py Outdated Show resolved Hide resolved
src/datasets/inspect.py Outdated Show resolved Hide resolved
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Can you just merge master into your branch ?
We just deprecated the script_version parameter in favor of revision in load_dataset_builder and prepare_module, so you might need to do a few adjustments

@lhoestq
Copy link
Member

lhoestq commented Sep 20, 2021

Should I add a section in https://github.com/huggingface/datasets/blob/master/docs/source/load_hub.rst? (there is no section for get_dataset_infos)

Yes totally :) This tutorial should indeed mention this, given how fundamental it is

@severo severo force-pushed the add-get-dataset-split-names branch from a679929 to ac27644 Compare October 4, 2021 09:05
@severo severo requested a review from lhoestq October 4, 2021 09:34
src/datasets/inspect.py Outdated Show resolved Hide resolved
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change and for adding it to the documentation :)
LGTM

@lhoestq lhoestq merged commit ba27ce3 into master Oct 4, 2021
@lhoestq lhoestq deleted the add-get-dataset-split-names branch October 4, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants