-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 馃幐 add a function to get a dataset config's split names #2906
Conversation
e51d0c3
to
7a6a485
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me ! Can you just merge master into your branch ?
We just deprecated the script_version
parameter in favor of revision
in load_dataset_builder
and prepare_module
, so you might need to do a few adjustments
Yes totally :) This tutorial should indeed mention this, given how fundamental it is |
`use_auth_token` can now be passed to the functions to get the configs or infos of private datasets on the hub
It's better for documentation, and removes dependency to prepare_module
a679929
to
ac27644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change and for adding it to the documentation :)
LGTM
Also: pass additional arguments (use_auth_token) to get private configs + info of private datasets on the hub
Questions:
-> no: reverted
-> yes: added