Add Jigsaw unintended Bias #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the tests seem to fail because of a bug in an Exception at the moment, see: #2936 for the fix |
lhoestq
reviewed
Sep 21, 2021
| @@ -0,0 +1,156 @@ | |||
| # coding=utf-8 | |||
| # Copyright 2020 The HuggingFace Datasets Authors and the current dataset script contributor. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2020 The HuggingFace Datasets Authors and the current dataset script contributor. | |
| # Copyright 2021 The HuggingFace Datasets Authors and the current dataset script contributor. |
There was a problem hiding this comment.
I had replaced this went back seeing as templates/new_dataset_script,py includes 2020. Might be worth updating this on your end.
|
@lhoestq implemented your changes, I think this might be ready for another look. |
lhoestq
reviewed
Sep 23, 2021
| # It is in charge of opening the given file and yielding (key, example) tuples from the dataset | ||
| # The key is not important, it's more here for legacy reason (legacy from tfds) | ||
|
|
||
| data = pd.read_csv(path) |
There was a problem hiding this comment.
This will load all the data in memory (1GB), could it be possible to iterate on the csv file line by line maybe ?
There was a problem hiding this comment.
Done, chunks of 50k now which should be small enough.
|
Thanks @lhoestq, implemented the changes, let me know if anything else pops up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here's a first attempt at this dataset. Would be great if it could be merged relatively quickly as it is needed for Bigscience-related stuff.
This requires manual download, and I had some trouble generating dummy_data in this setting, so welcoming feedback there.