Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new dataset kan_hope #2985

Merged
merged 4 commits into from
Oct 1, 2021
Merged

add new dataset kan_hope #2985

merged 4 commits into from
Oct 1, 2021

Conversation

adeepH
Copy link
Contributor

@adeepH adeepH commented Sep 29, 2021

Adding a Dataset

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this dataset !
And good job with the dataset script and dataset card

My only concern is that I think it's better if we have the labels in the other order, i.e. "Not-Hope" (0), "Hope" (1). I'm doing the change if you don't mind

datasets/kan_hope/README.md Outdated Show resolved Hide resolved
datasets/kan_hope/README.md Outdated Show resolved Hide resolved
datasets/kan_hope/README.md Outdated Show resolved Hide resolved
datasets/kan_hope/kan_hope.py Outdated Show resolved Hide resolved
datasets/kan_hope/README.md Outdated Show resolved Hide resolved
datasets/kan_hope/README.md Outdated Show resolved Hide resolved
datasets/kan_hope/kan_hope.py Outdated Show resolved Hide resolved
datasets/kan_hope/dataset_infos.json Outdated Show resolved Hide resolved
@lhoestq lhoestq merged commit 9adb14f into huggingface:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants