Fix cast to Python scalar in Matthews Correlation metric #3001
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is motivated by issue #2964.
The Matthews Correlation metric relies on sklearn's
matthews_corrcoef
function to compute the result. This function returns eitherfloat
ornp.float64
(see the source). Obviously, calling.item()
on the float value will fail, so I'm fixing this with the built-infloat()
function, which covers both cases. Surprisingly, on my machine, castingnp.float64
to a Python scalar withfloat()
is even faster than with the.item()
method.