Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend support for streaming datasets that use glob.glob #3015

Merged
merged 9 commits into from
Oct 5, 2021

Conversation

albertvillanova
Copy link
Member

This PR extends the support in streaming mode for datasets that use glob, by patching the function glob.glob.

Related to #2880, #2876, #2874

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks !

tests/test_streaming_download_manager.py Outdated Show resolved Hide resolved
tests/test_streaming_download_manager.py Outdated Show resolved Hide resolved
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@lhoestq lhoestq merged commit 2814fbd into master Oct 5, 2021
@lhoestq lhoestq deleted the streaming-glob branch October 5, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants