Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeDAL dataset: Add further description and update download URL #3022

Merged
merged 7 commits into from
Oct 13, 2021

Conversation

xhluca
Copy link

@xhluca xhluca commented Oct 5, 2021

Added more details in the following sections:

  • Dataset Structure
  • Data Instances
  • Data Splits
  • Source Data
  • Annotations
  • Discussions of Biases
  • LIcensing Information

@xhluca xhluca changed the title Add further details about the MeDAL dataset MeDAL dataset: Add further description and update download URL Oct 5, 2021
@xhluca
Copy link
Author

xhluca commented Oct 6, 2021

@lhoestq I'm a bit confused by the error message. I haven't touched the YAML code at all - do you have any insight on that?

@lhoestq
Copy link
Member

lhoestq commented Oct 8, 2021

I just added the missing pretty_name tag in the YAML - sorry about that ;)

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

I just regenerated the dataset_infos.json file and did a few changes in the Data Instances and Data Fields sections

@xhluca
Copy link
Author

xhluca commented Oct 10, 2021

Thanks! Seems like it did the trick since the tests are passing. Let me know if there's anything else I can do in this PR!

@lhoestq
Copy link
Member

lhoestq commented Oct 13, 2021

It's all good thank you :)

merging !

@lhoestq lhoestq merged commit 754336c into huggingface:master Oct 13, 2021
albertvillanova pushed a commit to aiinnova/huggingface_datasets that referenced this pull request Oct 13, 2021
…ngface#3022)

* Add further details about the MeDAL dataset

* Update the download link to the most recent version (v4)

* Change dummy data folder to 4.0.0

* Update README.md

* update infos

* nits in dataset card

* add @xhlulu to the list of contributors

Co-authored-by: Quentin Lhoest <42851186+lhoestq@users.noreply.github.com>
Co-authored-by: Quentin Lhoest <lhoest.q@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants