Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly install ruamel-yaml for windows CI #3028

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Oct 5, 2021

No description provided.

@lhoestq lhoestq merged commit 9622fed into master Oct 5, 2021
@lhoestq lhoestq deleted the properly-install-ruamel-yaml-for-windows-ci branch October 5, 2021 11:51
@albertvillanova
Copy link
Member

albertvillanova commented Oct 5, 2021

@lhoestq I would say this does not "properly" install ruamel-yaml, but the contrary, you overwrite the previous version without desinstalling it first.

According to pip docs:

This can break your system if the existing package is of a different version or was installed with a different package manager!

Note that our case fulfills both conditions:

  • the installing version (0.17.16) is different from the existing one (0.15.87)
  • you are installing using pip (setuptools), whereas the exisitng version was installed using distutils

That is why I did not fix the issue this way, made a hotfix pinning huggingface_hub (#3025), while looking for a permanent solution for the issue.

@lhoestq
Copy link
Member Author

lhoestq commented Oct 5, 2021

Yea I did this because we need the latest version of huggingface_hub for #2986 and because I didn't want to ssh to the windows worker x)
Maybe it can be fixed by installing it with conda - let me try

@lhoestq
Copy link
Member Author

lhoestq commented Oct 5, 2021

Oh yea it may not work since it was first installed with distutils

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants