More robust first elem check in encode/cast example #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
approved these changes
Dec 8, 2021
| ) | ||
| encoded_batch = features.encode_batch( | ||
| { | ||
| "x": [ |
There was a problem hiding this comment.
To be properly tested, does the first element has to be an empty list ?
There was a problem hiding this comment.
Yes, because encode_batch calls encode_nested_example which goes from the beginning of the list and tries to find the first element that is "good enough" to perform additional checks, and we consider an element "good enough" if it's not None or if it's not an empty sequence (possible nested). Previously, we would stop on the first element that is not None, but this could lead to issues such as the one this PR fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3306