-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate canonical Multilingual Librispeech #4060
Deprecate canonical Multilingual Librispeech #4060
Conversation
The documentation is not available anymore as the PR was closed or merged. |
Yes, as discussed in #4006 we should update facebook/multilingual_librispeech indeed before we do a release. @anton-l could you help taking care of updating facebook/multilingual_librispeech ? We need to update the task template task_templates=[AutomaticSpeechRecognition(audio_column="audio", transcription_column="text")], and write that Once the change is done we can merge this PR and do the release I think |
@polinaeterna @lhoestq |
Yes, there are several datasets with the same error, eg huggingface/dataset-viewer#188. I'm not sure what I should do to fix this? Upgrade datasets to master? |
@anton-l ended up removing the task template in facebook/multilingual_librispeech to make it work for the current version of |
@lhoestq can we merge now? ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, thanks :)
Deprecate canonical Multilingual Librispeech in favor of the community one which supports streaming.
However, there is a problem regarding new ASR template schema: since it's changed, I guess all community datasets that use this template do not work with new version of the library, including MLS. Should we somehow notify users about that or is it possible to change this line ourselves? For MLS specifically, I cannot change the code directly as I'm not the member of the Facebook org.
Hm, and the code should be change after the release, no?