Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct dataset type in from_generator docs #5307

Merged
merged 1 commit into from Nov 28, 2022
Merged

Use correct dataset type in from_generator docs #5307

merged 1 commit into from Nov 28, 2022

Conversation

mariosasko
Copy link
Contributor

Use the correct dataset type in the from_generator docs (example with sharding).

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 28, 2022 •
edited

The documentation is not available anymore as the PR was closed or merged.

lhoestq
lhoestq approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@mariosasko mariosasko merged commit 13b431a into main Nov 28, 2022
@mariosasko mariosasko deleted the fix-from_generator-docs branch November 28, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariosasko @HuggingFaceDocBuilderDev @lhoestq