Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support topdown parameter in xwalk #5308

Merged
merged 3 commits into from Dec 9, 2022
Merged

Support topdown parameter in xwalk #5308

merged 3 commits into from Dec 9, 2022

Conversation

mariosasko
Copy link
Contributor

Add support for the topdown parameter in xwalk when fsspec>=2022.11.0 is installed.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 28, 2022 •
edited

The documentation is not available anymore as the PR was closed or merged.

albertvillanova
albertvillanova reviewed Nov 30, 2022
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be simpler to define kwargs and put in the docs that these are forwarded to the underlying filesystem?

@albertvillanova albertvillanova changed the title Support topdown parameter in xwalk` Support topdown parameter in xwalk Nov 30, 2022
@mariosasko
Copy link
Contributor Author

I like the kwargs approach, thanks!

albertvillanova
albertvillanova approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice... Thanks!

@mariosasko mariosasko merged commit 8342781 into main Dec 9, 2022
@mariosasko mariosasko deleted the xwalk-topdown branch December 9, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariosasko @HuggingFaceDocBuilderDev @albertvillanova