Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extract] Place the lock file next to the destination directory #5320

Merged
merged 4 commits into from Dec 1, 2022

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Dec 1, 2022

Previously it was placed next to the archive to extract, but the archive can be in a read-only directory as noticed in #5295

Therefore I moved the lock location to be next to the destination directory, which is required to have write permissions

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 1, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is not passing. Apparently, there is an issue with DownloadConfig.delete_extracted...

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@lhoestq lhoestq merged commit 146a72e into main Dec 1, 2022
@lhoestq lhoestq deleted the fix-extract-lock branch December 1, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants